LGTM, as long as the legal department is in peace with the removed
copyright code comment .
On Tue, Jun 25, 2019 at 12:58 AM Nir Soffer <nsoffer(a)redhat.com> wrote:
On Mon, Jun 17, 2019 at 5:00 PM Nir Soffer <nsoffer(a)redhat.com>
wrote:
> On Mon, Jun 17, 2019 at 3:30 PM Vojtech Juranek <vjuranek(a)redhat.com>
> wrote:
>
>> Looks good to me
>>
>
> Thanks for reviewing.
>
> Lets wait for Amit since he has more experience with this code.
>
Amit, did you have time to look at these patches?
> Lately I spent lot of time reviewing changes to the this messy code, and
>> > it is time to clean up the mess. I'm planning many more cleanups, but
>> > this is enough for today.
>> >
>> > Nir Soffer (14):
>> > python: Remove CPyChecker support
>> > python: Rename __set_exception to set_sanlock_error
>> > python: Rename __parse_resource to parse_disks
>> > python: Rename __hosts_to_list to hosts_to_list
>> > python: Fix copyright years
>> > python: Add missing license blob to python files
>> > python: Remove meaningless "All rights reserved"
>> > python: Use C99 standard
>> > python: Limit the scope of for loop counter
>> > python: Remove unneeded check for null
>> > python: Streamline hosts_to_list
>> > python: Streamline py_get_lockspaces()
>> > python: Unify indentation
>> > python: Unify resource variables names
>> >
>> > python/example.py | 7 +
>> > python/sanlock.c | 310 ++++++++++++++++++++-----------------------
>> > python/setup.py | 3 +-
>> > tests/conftest.py | 6 +
>> > tests/constants.py | 6 +
>> > tests/daemon_test.py | 6 +
>> > tests/direct_test.py | 6 +
>> > tests/python_test.py | 6 +
>> > tests/storage.py | 6 +
>> > tests/units.py | 6 +
>> > tests/util.py | 6 +
>> > 11 files changed, 204 insertions(+), 164 deletions(-)
>> >
>> > --
>> > 2.17.2
>> > _______________________________________________
>> > sanlock-devel mailing list -- sanlock-devel(a)lists.fedorahosted.org
>> > To unsubscribe send an email to
>> sanlock-devel-leave(a)lists.fedorahosted.org
>> > Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
>> > List Guidelines:
>>
https://fedoraproject.org/wiki/Mailing_list_guidelines
>> > List Archives:
>> >
>>
https://lists.fedorahosted.org/archives/list/sanlock-devel@lists.fedorahost
>> >
ed.org
>>
>> _______________________________________________
>> sanlock-devel mailing list -- sanlock-devel(a)lists.fedorahosted.org
>> To unsubscribe send an email to
>> sanlock-devel-leave(a)lists.fedorahosted.org
>> Fedora Code of Conduct:
>>
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
>> List Archives:
>>
https://lists.fedorahosted.org/archives/list/sanlock-devel@lists.fedoraho...
>>
>