On Thu, Feb 2, 2023 at 10:14 PM <h-k-81(a)hotmail.com> wrote:
Hello everyone
While trying to fix the build of the `rust-fallible_collections` package
I found out [1] that the crate does not work properly with 32 bit systems.
I am not quite sure if my findings are 100% accurate but lets say they
are. What would be the best option here? Adding "ExcludeArch" to the
spec file?
Thank you for you answers in advance!
Hi!
I'm not familiar with this crate's code (it might be fine, for all I
know), but the tests themselves look like they're just begging for UB
and crashes :)
I think Josh is more familiar with this kind of stuff, but I think it
*should* be safe to just skip the test that crashes for Fedora builds
of rust-fallible_collections.
Side note: You might not even really need this crate - many APIs for
fallible allocations have recently been added to the Rust standard
library.
For example Vec::try_reserve has been stable since Rust 1.57:
https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.try_reserve
So depending on what the crate that depends on these APIs needs, you
might be able to ditch the dependency on fallible_collections
entirely.
Fabio