On Fri, Mar 10, 2023 at 6:23 PM Sergio Lopez <slp(a)redhat.com> wrote:
On Fri, Mar 10, 2023 at 11:02 PM Fabio Valentini
<decathorpe(a)gmail.com> wrote:
> On Fri, Mar 10, 2023 at 10:57 PM David Michael <fedora.dm0(a)gmail.com> wrote:
> > On Thu, Mar 9, 2023 at 7:30 PM David Michael <fedora.dm0(a)gmail.com>
wrote:
> > > This is only a first step to update the crates already in Fedora. I
> > > have the full set of crates together in a Git repo[1]. If the PRs
> > > look okay, I can start submitting review requests for the new crates.
> >
> > A quick follow up to this, the criterion dependencies were patched
> > out, so the list of PRs is now:
> >
> >
https://src.fedoraproject.org/rpms/rust-crypto-common/pull-request/1
> >
https://src.fedoraproject.org/rpms/rust-universal-hash/pull-request/1
> >
https://src.fedoraproject.org/rpms/rust-polyval/pull-request/1
> >
https://src.fedoraproject.org/rpms/rust-ghash/pull-request/1
> >
https://src.fedoraproject.org/rpms/rust-aead/pull-request/1
> >
https://src.fedoraproject.org/rpms/rust-aes-gcm/pull-request/1
> >
https://src.fedoraproject.org/rpms/rust-cookie/pull-request/1
>
> Sorry, I've been out sick today. Not sure if I'll be able to review
> your PRs this weekend.
>
> > In addition, there are two older compatibility packages for crates
> > already in Fedora. The guidelines say they don't require a package
> > review, but does anyone want to quickly look over the specs anyway?
> > They shouldn't be notably different from the latest packaged crates.
> >
> >
https://github.com/dm0-/copr-firecracker/blob/master/rust-bindgen0.60.spec
> >
https://github.com/dm0-/copr-firecracker/blob/master/rust-kvm-ioctls0.12....
>
> Before you create a compat package for bindgen 0.60, consider patching
> the crate that uses it to use either v0.59 or v0.63.
> The API differences between bindgen versions are usually really small,
> so patching the dependency to be on bindgen v0.63 instead of v0.60
> should work just fine.
Same goes for rust-kvm-ioctls. From the experience of supporting 0.13 in libkrun (which
has a very similar code base), this should only require a very small patch.
Okay, the diff between versions just looks like additions to the API,
so I've added a patch to firecracker.spec to update it. Now there are
no compat packages.
Relatedly, there are two new crates (cargo_toml and crc64) that have
version requirements older than their latest branch on crates.io, and
I added the specs with a version suffix to indicate the branch
dependency. Is that an acceptable way to handle it, or should new
crates always be unsuffixed and have their users be patched whenever
they're updated?
Thanks.
David