-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/208/#review515
-----------------------------------------------------------
src/rolekit/server/rolebase.py (lines 1049 - 1050)
<
http://reviewboard-fedoraserver.rhcloud.com/r/208/#comment306>
You copy-and-paste this code a lot. Can we just extend change_state() to take an
optional error message and set the lasterror inside it instead?
- Stephen Gallagher
On Sept. 9, 2015, 4:53 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/208/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 4:53 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
The lasterror property in role instances is currently not set. But it should
be set for example for failed deploys, where the error then will be stored in
the backup of the settings file.
Depends on
https://github.com/libre-server/rolekit/issues/49
Fixes:
https://github.com/libre-server/rolekit/issues/50
Diffs
-----
src/rolekit/server/decorators.py 415c6911ea8e3c11b92bf3ada81190c3c8d8d742
src/rolekit/server/rolebase.py 55add0077016c92eff2c9699b13e5c7d6026e574
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/208/diff/
Testing
-------
Thanks,
Thomas Woerner