-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/209/#review524
-----------------------------------------------------------
I ran several deployments, decommissions and settings-lookups. The patch appears to be
working as expected. Just a few minor nitpicks to clean up.
src/rolekit/dbus_utils.py (lines 195 - 196)
<
http://reviewboard-fedoraserver.rhcloud.com/r/209/#comment312>
rolekit is Python3-only. I suspect we can skip this.
src/rolekit/dbus_utils.py (lines 197 - 198)
<
http://reviewboard-fedoraserver.rhcloud.com/r/209/#comment313>
Shouldn't we do repr(obj) here, lest we discover it's something unprintable?
src/rolekit/dbus_utils.py (lines 200 - 211)
<
http://reviewboard-fedoraserver.rhcloud.com/r/209/#comment314>
Would you mind dumping the doc.toxml() out to debug level 10? I think it would be
useful to be able to inspect it if we have issues.
- Stephen Gallagher
On Sept. 9, 2015, 9:38 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/209/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 9:38 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
With the upstream rejection of the dbus-python properties patch
https://bugs.freedesktop.org/show_bug.cgi?id=26903#c14
there is a need to have an alternative way to have properties in the D-Bus
interfaces.
The inspiration for this solution is from Tony Asleson
https://github.com/tasleson/lvm-dubstep.git
Diffs
-----
config/roles/databaseserver/role.py 684101d957339ef9c66de0074abf58d3d77d1f76
config/roles/domaincontroller/role.py f7536dcd811edc1c4c0d2c97ef194030b07d1bed
config/roles/memcache/role.py ba9d41243352e2546847856a7d4ac6936cf8862f
config/roles/testrole/role.py 3b03fd42f0a116c25221371b38617d6a8f08b80c
src/rolekit/dbus_utils.py 1329a587a369956c8643ab426c42f321034262b9
src/rolekit/server/dbusrole.py f751b2e00df1a81856906f9452ac018f06348fca
src/rolekit/server/rolebase.py 55add0077016c92eff2c9699b13e5c7d6026e574
src/rolekit/server/roled.py 2774156b7dfa296f873f21b820def1955e66a4f4
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/209/diff/
Testing
-------
Thanks,
Thomas Woerner