On Aug. 5, 2015, 8:33 a.m., Nils Philippsen wrote:
> src/rolekit/server/rolebase.py, lines 645-649
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/181/diff/1/?file=822#file82...
>
> Why use `job_handler.manager.DisableUnitFiles()` here, but `enable_units()`
(from `rolekit.server.io.systemd`) above? The symmetrical `disable_units()` is imported as
well.
This was an oversight. I added the ```enable_units()```/```disable_units()``` routines
after I realized that the ```Reload()``` was necessary and missed updating that spot.
Thanks for catching it!
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/181/#review456
-----------------------------------------------------------
On Aug. 5, 2015, 1:31 a.m., Stephen Gallagher wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/181/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 1:31 a.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.
Bugs: 30
http://github.com/libre-server/rolekit/issues#issue/30
Repository: rolekit
Description
-------
We run start() internally at the end of deployment, so changes to the start() routine
also address the specific issue described in ticket #30
Fixes
https://github.com/libre-server/rolekit/issues/30
Diffs
-----
src/rolekit/server/rolebase.py b8bc640bd70fe995e4183c71bd77b355a42a4228
doc/xml/rolekit.dbus.xml 1f876763a5189935c42f3c779d659f9e2b3bf987
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/181/diff/
Testing
-------
Started and stopped roles repeatedly, checking ```systemctl status
<instance>.service``` between each attempt.
Thanks,
Stephen Gallagher