This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/181/

src/rolekit/server/rolebase.py (Diff revision 1)
def restartServices(self):
645
646
            log.debug9("Disabling %s" % target_unit)
647
            job_handler.manager.DisableUnitFiles([target_unit], False)
648
649
            log.debug9("Stopping %s" % target_unit)

Why use job_handler.manager.DisableUnitFiles() here, but enable_units() (from rolekit.server.io.systemd) above? The symmetrical disable_units() is imported as well.


- Nils Philippsen


On August 5th, 2015, 3:31 vorm. CEST, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Aug. 5, 2015, 3:31 vorm.

Bugs: 30
Repository: rolekit

Description

We run start() internally at the end of deployment, so changes to the start() routine also address the specific issue described in ticket #30

Fixes https://github.com/libre-server/rolekit/issues/30

Testing

Started and stopped roles repeatedly, checking systemctl status <instance>.service between each attempt.

Diffs

  • src/rolekit/server/rolebase.py (b8bc640bd70fe995e4183c71bd77b355a42a4228)
  • doc/xml/rolekit.dbus.xml (1f876763a5189935c42f3c779d659f9e2b3bf987)

View Diff