-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/143/#review395
-----------------------------------------------------------
doc/xml/rolekit.roles.domaincontroller.xml
<
http://reviewboard-fedoraserver.rhcloud.com/r/143/#comment219>
This change looks good, but it's not the only place we made this capitalization
mistake, unfortunately. (It's annoying that JSON and Python use different
capitalization for boolean values).
Could you please correct any other instance of True and False to 'true' and
'false' in the roles? Might as well get them all solved at the same time.
- Stephen Gallagher
On March 5, 2015, 2:56 p.m., Dan Mossor wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/143/
-----------------------------------------------------------
(Updated March 5, 2015, 2:56 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
Corrected a typo in the example settings.json section.
Diffs
-----
doc/xml/rolekit.roles.domaincontroller.xml 686739d19afffabdcc1abd592e0e1921c9c907ae
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/143/diff/
Testing
-------
Thanks,
Dan Mossor