This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/143/

doc/xml/rolekit.roles.domaincontroller.xml (Diff revision 1)
250
  "serve_dns": True,
250
  "serve_dns": true,

This change looks good, but it's not the only place we made this capitalization mistake, unfortunately. (It's annoying that JSON and Python use different capitalization for boolean values).

Could you please correct any other instance of True and False to 'true' and 'false' in the roles? Might as well get them all solved at the same time.


- Stephen Gallagher


On March 5th, 2015, 2:56 p.m. UTC, Dan Mossor wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Dan Mossor.

Updated March 5, 2015, 2:56 p.m.

Repository: rolekit

Description

Corrected a typo in the example settings.json section.

Diffs

  • doc/xml/rolekit.roles.domaincontroller.xml (686739d19afffabdcc1abd592e0e1921c9c907ae)

View Diff