-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/122/#review356
-----------------------------------------------------------
src/rolekit/server/dbusrole.py
<
http://reviewboard-fedoraserver.rhcloud.com/r/122/#comment187>
I think it makes more sense to set the _MAX_INSTANCES default value in RoleBase and
then just allow the role implementations to override it if they want to. It seems less
complex.
- Stephen Gallagher
On Nov. 7, 2014, 7:34 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/122/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 7:34 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
If _MAX_INSTANCES is defined in the role, then it will be used as the maximum
count of instances for this role. If is is not defined, the global
MAX_INSTANCES definition will be used.
To set a different maximum instance count, add _MAX_INSTANCES=X to the Role
definition in role.py next to _DEFAULTS and _READONLY_SETTINGS.
Diffs
-----
src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing
-------
Thanks,
Thomas Woerner