-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/199/#review501
-----------------------------------------------------------
Ship it!
Looks good to me, I tested it with `rolectl deploy databaseserver <TAB><TAB>`
(which offered all options) and `rolectl deploy databaseserver --settings-stdin
<TAB><TAB>` and it seems to do the right thing (i.e. complete `--name`).
- Nils Philippsen
On Aug. 27, 2015, 11:14 vorm., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/199/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 11:14 vorm.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Only suggest --settings-stdin if --settings-file was not passed and vice-versa.
Fixes
https://github.com/libre-server/rolekit/issues/38
Diffs
-----
shell-completion/bash/rolectl cc9b329059e5b8d6f719537e9cab97a599281ab6
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/199/diff/
Testing
-------
Thanks,
Thomas Woerner