-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/30/#review110
-----------------------------------------------------------
src/rolectl
<
http://reviewboard-fedoraserver.rhcloud.com/r/30/#comment83>
You reuse this everywhere. While I realize it's only two lines, that much exact
duplication is wasteful.
Please just create an instance_obj up at the top before the if/else and just consume
it in each of the conditionals.
src/rolectl
<
http://reviewboard-fedoraserver.rhcloud.com/r/30/#comment84>
s/uncatched/uncaught/
- Stephen Gallagher
On July 22, 2014, 3:09 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/30/
-----------------------------------------------------------
(Updated July 22, 2014, 3:09 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Provides commands: version, list, settings, deploy, redeploy, status, start, stop,
restart, update and decommission
Diffs
-----
src/rolectl 47044818ee66f0f12af4682ef19360f85db89180
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/30/diff/
Testing
-------
Thanks,
Thomas Woerner