This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/30/

src/rolectl (Diff revision 2)
237
    splits = a.instance.split("/")
238
    obj = rk.getNamedRoleObj(splits[0]).getNamedInstanceObj(splits[1])

You reuse this everywhere. While I realize it's only two lines, that much exact duplication is wasteful.

Please just create an instance_obj up at the top before the if/else and just consume it in each of the conditionals.


src/rolectl (Diff revision 2)
285
    __fail("Uncatched argument")

s/uncatched/uncaught/


- Stephen Gallagher


On July 22nd, 2014, 3:09 p.m. UTC, Thomas Woerner wrote:

Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Thomas Woerner.

Updated July 22, 2014, 3:09 p.m.

Repository: rolekit

Description

Provides commands: version, list, settings, deploy, redeploy, status, start, stop, restart, update and decommission

Diffs

  • src/rolectl (47044818ee66f0f12af4682ef19360f85db89180)

View Diff