On Srp. 19, 2014, 2:49 odp., Stephen Gallagher wrote:
> src/rolekit/async.py, lines 157-159
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/56/diff/1/?file=240#file240...
>
> You added excess whitespace here. No need to resubmit for review, just clean it
before pushing, please.
https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=d03f6944ac66db2c...
- Miloslav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/56/#review226
-----------------------------------------------------------
On Srp. 19, 2014, 4:34 odp., Miloslav Trmac wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/56/
-----------------------------------------------------------
(Updated Srp. 19, 2014, 4:34 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
This really does call for a decorator that allows us to just say
@dbus_service_method_async
def deploy_async(..., no_handlers_here):
yield None
but that’s for later.
Diffs
-----
src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5
src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15
src/rolekit/server/decorators.py a0c8cf4a86a7391843c33b98e344532b564868e5
src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/56/diff/
Testing
-------
Thanks,
Miloslav Trmac