On Sept. 2, 2015, 3:25 p.m., Nils Philippsen wrote:
config/roles/domaincontroller/role.py, lines 273-277 http://reviewboard-fedoraserver.rhcloud.com/r/203/diff/2/?file=1009#file1009line273
Do you want to resurrect this code later? If not, these lines should just go away.
Oops, I commented those out for testing only.
On Sept. 2, 2015, 3:25 p.m., Nils Philippsen wrote:
config/roles/domaincontroller/role.py, lines 279-286 http://reviewboard-fedoraserver.rhcloud.com/r/203/diff/2/?file=1009#file1009line279
The `raise` in line 266 prevents any later lines from being executed, should they just go away, or is this in the wrong place?
Ditto above. This was just in there to make testing this fast (by skipping the actual deployment)
- Stephen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/203/#review506 -----------------------------------------------------------
On Sept. 2, 2015, 2:14 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/203/
(Updated Sept. 2, 2015, 2:14 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Bugs: 43 http://github.com/libre-server/rolekit/issues#issue/43
Repository: rolekit
Description
This patch changes the default behavior of the domain controller role. After discussions with UXD experts, it was determined that the domain should never be auto-detected from the environment, since it is very difficult to change later. It should always come from some user action.
This patch changes the default domain to use the role instance name for the domain name, as long as the instance name contains valid characters. It also changes the behavior of the host_name option to set the hostname to dc-<16 characters> if it is currently set to localhost.
Fixes https://github.com/libre-server/rolekit/issues/43
Diffs
config/roles/domaincontroller/role.py 62d2bc64d6efb9c2b7e254c8d61c612f05e4c4be doc/xml/rolekit.roles.domaincontroller.xml 2416c889ba0035dc6247b2eb209dbe13eb3b9708
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/203/diff/
Testing
Deployed multiple domain controllers with varying initial hostnames.
Thanks,
Stephen Gallagher