This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/203/

On September 2nd, 2015, 3:25 p.m. UTC, Nils Philippsen wrote:

config/roles/domaincontroller/role.py (Diff revision 2)
249
        result = yield async.subprocess_future(ipa_install_args)
260
        # result = yield async.subprocess_future(ipa_install_args)
261
        #
262
        # if result.status:
263
        #     # If the subprocess returned non-zero, raise an exception
264
        #     raise RolekitError(COMMAND_FAILED, "%d" % result.status)

Do you want to resurrect this code later? If not, these lines should just go away.

Oops, I commented those out for testing only.


On September 2nd, 2015, 3:25 p.m. UTC, Nils Philippsen wrote:

config/roles/domaincontroller/role.py (Diff revision 2)
251
        if result.status:
266
        raise NotImplementedError
252
            # If the subprocess returned non-zero, raise an exception
253
            raise RolekitError(COMMAND_FAILED, "%d" % result.status)
254
267
255
        # Create the systemd target definition
268
        # Create the systemd target definition
256
        target = {'Role': 'domaincontroller',
269
        target = {'Role': 'domaincontroller',
257
                  'Instance': self.get_name(),
270
                  'Instance': self.get_name(),
258
                  'Description': "Domain Controller Role - %s" %
271
                  'Description': "Domain Controller Role - %s" %

The raise in line 266 prevents any later lines from being executed, should they just go away, or is this in the wrong place?

Ditto above. This was just in there to make testing this fast (by skipping the actual deployment)


- Stephen


On September 2nd, 2015, 2:14 p.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Sept. 2, 2015, 2:14 p.m.

Bugs: 43
Repository: rolekit

Description

This patch changes the default behavior of the domain controller
role. After discussions with UXD experts, it was determined that
the domain should never be auto-detected from the environment,
since it is very difficult to change later. It should always come
from some user action.

This patch changes the default domain to use the role instance name
for the domain name, as long as the instance name contains valid
characters. It also changes the behavior of the host_name option to
set the hostname to dc-<16 characters> if it is currently set to
localhost.

Fixes https://github.com/libre-server/rolekit/issues/43

Testing

Deployed multiple domain controllers with varying initial hostnames.

Diffs

  • config/roles/domaincontroller/role.py (62d2bc64d6efb9c2b7e254c8d61c612f05e4c4be)
  • doc/xml/rolekit.roles.domaincontroller.xml (2416c889ba0035dc6247b2eb209dbe13eb3b9708)

View Diff