I ended up committing this stuff in.
NOTE: IF YOU DID A DBSETUP WITHIN THE LAST 12 DAYS FROM MASTER OR DRIFT
BRANCH, YOU MUST DROP YOUR DB IN ORDER TO RESETUP THE DB AGAIN!
I collapsed the two db-upgrades into one (since it appears the original
table was really new - 12 days old - there is no reason to have a
separate db-upgrade step, it just means any developer who did a
dbsetup/upgrade within the last 12 days ago or so needs to purge the
old table manually if they want to dbsetup again).
I also merged master into the drift branch (and again, resolving the
conflicts !?@#$) and things should now be good.
On 06/27/2011 05:19 PM, John Mazzitelli wrote:
Heiko,
I see that you renamed a table in the last db-upgrade step. But this was
a table you just created within the last week or two IIRC.
I'm having dbsetup problems due to this - I can't dbsetup because the
table was renamed, and well, there are issues if we remove tables from
dbsetup - we need to flag these as obsoleted tables in the obsolete
schema. However, we only use that for supported tables (things we
released with) that we obsolete. Since this is a work in progress (and
the "original" table won't exist in released version - in fact, it has
only lived for a couple weeks!) we should not worry about it (i.e. we
should not create db-upgrade steps to rename it)
What you should do is collapse all your db-upgrade steps into one. Don't
worry about the renamed table, and just use the new table name (i.e.
create the new table in db-upgrade and do not worry about renaming it)
This way, dbsetup/dbupgrade is simpler, more compact.
Yes, this means developers need to blow away their DB if they need the
new stuff. So be it. That's what I am going to have to do anyway since
this isn't working for me anyway. So I didn't gain anything no matter what.
It also makes it easier for you, you don't have to start creating crazy
db-upgrade steps as you are developing this stuff.
And it makes it easier for the drift guys have have to merge master and
keep getting conflicts in the db-upgrade and pom.xml :)
_______________________________________________
rhq-devel mailing list
rhq-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/rhq-devel