Hey,
when changing the signatures of existing non-private methods,
please run the api-checker job locally before committing / pushing the
change or submitting a patch. You can do that via
$ mvn -Psignature-check -DskipTests clean install
If the change is intentional, it needs to be recorded in the respective
file until the above check succeeds.
I had in EventSource. java for demonstration purposes changed the return type
for a getter from int to Integer.
The build now fails and the api checker shows:
[INFO] --- clirr-maven-plugin:2.5:check (signature-check) @ rhq-core-domain ---
[ERROR] org.rhq.core.domain.event.EventSource: Rückgabetyp der Methode 'public int
getResourceId()' wurde zu java.lang.Integer geändert
Thanks
Heiko
--
Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,
Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
Handelsregister: Amtsgericht München HRB 153243
Geschaeftsführer: Mark Hegarty, Charlie Peters, Michael Cunningham, Charles Cachera
Show replies by date