modules/core/client-api/src/main/java/org/rhq/core/clientapi/agent/metadata/DriftMetadataParser.java
| 3 ++-
modules/core/client-api/src/test/java/org/rhq/core/clientapi/agent/metadata/test/PluginMetadataParserTest.java
| 3 ++-
modules/core/domain/src/main/java/org/rhq/core/domain/drift/DriftConfigurationDefinition.java
| 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
New commits:
commit 94fe685ea78d43c0c5d24204662f07816b4c3265
Author: John Sanda <jsanda(a)redhat.com>
Date: Mon Aug 29 13:13:31 2011 -0400
Enable drift configurations by default
diff --git
a/modules/core/client-api/src/main/java/org/rhq/core/clientapi/agent/metadata/DriftMetadataParser.java
b/modules/core/client-api/src/main/java/org/rhq/core/clientapi/agent/metadata/DriftMetadataParser.java
index c7c0a12..4d95331 100644
---
a/modules/core/client-api/src/main/java/org/rhq/core/clientapi/agent/metadata/DriftMetadataParser.java
+++
b/modules/core/client-api/src/main/java/org/rhq/core/clientapi/agent/metadata/DriftMetadataParser.java
@@ -56,7 +56,8 @@ public class DriftMetadataParser {
}
private void initEnabled(ConfigurationTemplate template) {
- template.getConfiguration().put(new
PropertySimple(DriftConfigurationDefinition.PROP_ENABLED, false));
+ template.getConfiguration().put(new
PropertySimple(DriftConfigurationDefinition.PROP_ENABLED,
+ DriftConfigurationDefinition.DEFAULT_ENABLED));
}
private void initName(DriftDescriptor descriptor, ConfigurationTemplate template) {
diff --git
a/modules/core/client-api/src/test/java/org/rhq/core/clientapi/agent/metadata/test/PluginMetadataParserTest.java
b/modules/core/client-api/src/test/java/org/rhq/core/clientapi/agent/metadata/test/PluginMetadataParserTest.java
index 572bb10..7adf6fa 100644
---
a/modules/core/client-api/src/test/java/org/rhq/core/clientapi/agent/metadata/test/PluginMetadataParserTest.java
+++
b/modules/core/client-api/src/test/java/org/rhq/core/clientapi/agent/metadata/test/PluginMetadataParserTest.java
@@ -22,6 +22,7 @@ import static
org.rhq.core.clientapi.shared.PluginDescriptorUtil.toPluginDescrip
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertNotNull;
+import static org.testng.Assert.assertTrue;
import java.util.HashMap;
import java.util.List;
@@ -823,7 +824,7 @@ public class PluginMetadataParserTest {
"The value is wrong for the <name> property that represents the
drift configuration name");
assertNotNull(enabled, "Expected to find simple property <enabled> for
the drift configuration");
- assertFalse(enabled.getBooleanValue(), "The <enabled> property should
be set to a default value of false");
+ assertTrue(enabled.getBooleanValue(), "The <enabled> property should
be set to a default value of true");
test.assertDriftTemplate(driftTemplate);
}
diff --git
a/modules/core/domain/src/main/java/org/rhq/core/domain/drift/DriftConfigurationDefinition.java
b/modules/core/domain/src/main/java/org/rhq/core/domain/drift/DriftConfigurationDefinition.java
index dfdc54a..e669a9a 100644
---
a/modules/core/domain/src/main/java/org/rhq/core/domain/drift/DriftConfigurationDefinition.java
+++
b/modules/core/domain/src/main/java/org/rhq/core/domain/drift/DriftConfigurationDefinition.java
@@ -62,7 +62,7 @@ public class DriftConfigurationDefinition implements Serializable {
// Thus, we only allow config names to only include spaces or "." or
"-" or alphanumeric or "_" characters.
public static final String PROP_NAME_REGEX_PATTERN = "[ \\.\\-\\w]+";
- public static final boolean DEFAULT_ENABLED = false;
+ public static final boolean DEFAULT_ENABLED = true;
public static final long DEFAULT_INTERVAL = 1800L;
/**
Show replies by date