modules/core/util/intentional-api-changes-since-4.4.0.xml | 15
++++++++++
modules/core/util/src/main/java/org/rhq/core/util/exec/ProcessExecutor.java | 3 +-
2 files changed, 17 insertions(+), 1 deletion(-)
New commits:
commit 8cdbab3e33cbeb42ce8ef30a863c9d5e3420bd80
Author: Lukas Krejci <lkrejci(a)redhat.com>
Date: Fri Sep 21 14:46:44 2012 +0200
[BZ 803737] - Adding API difference justification for code change introduced
by commit bf4b25f421769909e886eb42f7b99c66b207b200.
diff --git a/modules/core/util/intentional-api-changes-since-4.4.0.xml
b/modules/core/util/intentional-api-changes-since-4.4.0.xml
new file mode 100644
index 0000000..bcbe4e5
--- /dev/null
+++ b/modules/core/util/intentional-api-changes-since-4.4.0.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0"?>
+<differences>
+ <difference>
+ <className>org/rhq/core/util/exec/ProcessExecutor</className>
+ <differenceType>7006</differenceType><!-- method return type
changed -->
+ <method>void redirectStreams(*)</method>
+ <to>org.rhq.core.util.exec.ProcessExecutor$RedirectThreads</to>
+ <justification>
+ This is a protected method and thus accessible only to subclasses. No known
subclasses exist.
+ This is a source-compatible change though (this method used to be void so no
caller could have
+ used the return type) so if there exists a subclass in the 3rd party code, it
is going to
+ be enough for that code to be recompiled to start working again.
+ </justification>
+ </difference>
+</differences>
commit 9f7142e9d8f5e7dd816f2dadfb92cc4f638a7296
Author: Lukas Krejci <lkrejci(a)redhat.com>
Date: Fri Sep 21 14:43:58 2012 +0200
Adding generic signature and @Override to get rid of code-style warnings.
diff --git a/modules/core/util/src/main/java/org/rhq/core/util/exec/ProcessExecutor.java
b/modules/core/util/src/main/java/org/rhq/core/util/exec/ProcessExecutor.java
index 308d9bd..390bb5e 100644
--- a/modules/core/util/src/main/java/org/rhq/core/util/exec/ProcessExecutor.java
+++ b/modules/core/util/src/main/java/org/rhq/core/util/exec/ProcessExecutor.java
@@ -104,7 +104,8 @@ public class ProcessExecutor {
// wait if told to - note that the default is not to wait
if (process.getWaitForExit().intValue() > 0) {
- Callable<Integer> call = new Callable() {
+ Callable<Integer> call = new Callable<Integer>() {
+ @Override
public Integer call() throws Exception {
Thread.currentThread().setName("ExecuteProcess-" +
process.getProgramTitle());
try {
Show replies by date