On April 25, 2013, 1:18 p.m., Jan Safranek wrote:
> src/openlmi/storage/LMI_MountConfigurationService.py, line 275
>
<
http://reviewboard-openlmi.rhcloud.com/r/254/diff/1/?file=1447#file1447li...
>
> either return non-positive 'rval' or set error, not both. IMHO it's
enough to 'raise CIMError(...), the job will handle the rest automatically.
>
> Dtto for DeleteMount.
Raising CIMError is not handled in the job, it will show in the log as a python
traceback.
And I think I should set both rval and error. Setting only error/rval and ignoring the
other one seems weird to me.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/254/#review294
-----------------------------------------------------------
On April 24, 2013, 2:15 p.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/254/
-----------------------------------------------------------
(Updated April 24, 2013, 2:15 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add LMI_MountConfigurationService.
Diffs
-----
mof/LMI_Storage.reg e0eb237150618f0e561294d1d5354857ddf23adf
src/openlmi/storage/LMI_MountConfigurationService.py PRE-CREATION
src/openlmi/storage/MountingProvider.py PRE-CREATION
src/openlmi/storage/cimom_entry.py 7157f7d21dff4751905e9f36d115e57d2f397a9d
Diff:
http://reviewboard-openlmi.rhcloud.com/r/254/diff/
Testing
-------
Thanks,
Jan Synacek