-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/23/2014 03:31 PM, Jan Safranek wrote:
The second version looks production-ready, just two remarks:
On 04/17/2014 10:23 AM, Jan Synacek wrote:
>>> - LMI_SELinuxFile: we already have context and expected context as
>>> properties of LMI_UnixFile, it does not seem appropriate to provide them
>>> again in LMI_SELinuxFile (rendering LMI_SELinuxElementWithContext
>>> practically useless...)
>>> - also, enumeration of this class must be disabled, which makes
>>> creation of references pretty hard.
> I wanted the file class to fit into the whole model -- inherit from
> LMI_SELinuxElement. I know about the contexts in LMI_UnixFile and I wanted
> to remove them from there. The best solution would probably be if
> LMI_UnixFile inherited from LMI_SELinuxElement, which would be multiple
> inheritance and that is not allowed.
We cannot easily remove stuff from already published LogicalFile
provider, it would need to bump major version for that.
Stick to the attributes in LMI_UnixFile and don't create redundant ones
in SELinux provider.
Fixed.
>> - LMI_SELinuxService.RestoreLabel: it should also export list
of changes
>> it did, in the very same way as GetMislabeledFiles() should do. Maybe
>> there could be just one method with two modes - dry run / normal run?
>
> Good point. Redesigned.
LMI_SELinuxService.ProcessTarget() is really bad name, all it can do is
to check and optionally restore labels on mislabeled files, what about:
uint32 CheckFiles(string Target, uint16 Action('fix'/'report only'),
boolean Recursively, [out] Job)
Ok, I changed the name to RestoreLabels, so it has "Restore" in the name,
as "restorecon" does.
- --
Jan Synacek
Software Engineer, Red Hat
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iQIcBAEBAgAGBQJTWPCTAAoJEL3BmMJQOtjBA20P/0LnscFGbnPINauHCDvp63n4
1B8jMjJMjjdwkYfcOuxay+ADmnH7caL9XhAB7yIeUJ4EdhkzAsF0bdEnps3a6vqu
uxY68Kvvbmv1r1sM93i4ZukHC6qGQEYQI7xlR/Px1eWDYUFJ555x8ImPfLZZyAyv
qfCfeIHbyTY3e4oo85MbuD+OGuY3NN6tE2JmvfZB65sMw/KrXTj27fN5rYTwvge6
hQIBHXveCHtbVraON8JeH+muFyUEjCo++AURB8zGyKPxFQ8Vul8ugyqLUjPuWYds
OqRsY8ZoXRkjyApuitYhOEM56eBXbEfZWLuDSURium0Orz5t1A563yCxRZwMbLgr
xen7koJrWgjW/1154otDkdGd7EAuC3ttmFTN2aoLv5n6qfTnpcnHWyREfSD9WbLJ
WiE5XH/7M2V9ofBZe18jlLfk/dTgPgu1Z2fGRWYovYu275T9HwKUg2XmXrlgQHJv
7hupaPo+SrFxzzd5sWAFB+2keTOl0pWk8xNKuM7CQny/DFw+r0AtxUG+koMlA3HG
B+5+mp5NXEGss8yhpzWV+uol61z7jfXsGIDdxlCBrEvsw4cDWMGWNKhNTJsi8KV1
I4QX4hF46ArHqcO285eekN0sGL8N1ggoqK8uD2Qm3NtG331Vxt3ZUI/hMPyPq3ia
3ixUestc7mE2/xvAWqDP
=h4JV
-----END PGP SIGNATURE-----