On Monday, March 17, 2014 22:17:57 Kai Engert wrote:
I commited a few changes:
https://git.fedorahosted.org/cgit/nss-pem.git/commit/?id=cf9834b1ccc3ed6a16e
57e203b2dae38a5cd9c8a
All changes have passed all the tests that I have. Local testing with
curl/pem/selfserv, and inhouse PEM regression tests.
If you want to give this more testing or review, I'll appreciate it.
I would prefer one commit per issue, so that we can use git-bisect to locate
regressions later on.
[...]
- in CreateObject with CKO_PRIVATE_KEY, don't reset
the nickname back to filename contents, seems wrong
As already discussed off-list, the above line was added on purpose to fix
(or work around?) a real bug:
https://bugzilla.redhat.com/show_bug.cgi?id=689031#c66
It might be no longer necessary with up2date versions of packages using NSS,
but we should be careful when removing the line. In particular, we should
double-check that the patch in question does not reintroduce the above bug.
Kamil