On Do, 2014-01-23 at 12:23 +0100, Kai Engert wrote:
do you allow me to apply
0039-Sync-up-with-nss-3.15.4-changes-in-freebl-and-softok.patch
to
https://git.fedorahosted.org/cgit/nss-pem.git/ ?
Kamil has done that in the meantime, thanks!
I notice that file rsawrapr.c has several sections that are disabled
with
#if 0
#endif
For better readability, I would like to
- either remove those blocks
- or move those blocks to a separate file rsawrapr-unsused.c
Is that ok? Any preference?
Also in the meantime, I've started this ticket:
https://fedorahosted.org/nss-pem/ticket/3
that suggests to avoid the copies of NSS RSA code that we currently have
in file rsawrapr.c
In that ticket, I've suggested a modification to function pem_RSA_Sign.
I believe the change is functionally equivalent.
As a result of that change, a lot of code in file rsawrapr.c would
become unnecessary.
I've attached a full patch to the ticket, which removes all the code
that's no longer necessary to build, and moved it to the new file
rsawrapr-unused.c
If you cannot think of a good reason to keep the old code, we could
simply remove them completely (and not create rsawrapr-unused.c)
Looking forward to your toughts.
Thanks,
Kai