----- "Daniel P. Berrange" <berrange(a)redhat.com> wrote:
> @@ -163,7 +168,9 @@
> int match = -1;
> for (int i=0; i < nhwaddr; i++) {
> const char *addr;
> +#ifdef HAVE_LIBAUGEAS
> r = aug_get(aug, hwaddr[i], &addr);
> +#endif
IMHO this is a pretty bad way to go about this. It is merely
making the code compile by deleting lines which are broken.
The resulting code will be totally non-functional, eg because
'r' in this case will be left uninitialized.
This source code file is basically Linux/Fedora specific, so
for Win32, it would be better to add a conditional rule to
the Makefile.am to skip compilation of the entire file. This
avoids the need to fill it with unusable #ifdefs.
Thanks for the input Dan, I totally agree and will look at an alternative approach
to this porting effort.
--
__ __
.-----.| |_.-----.| |--.-----.-----.
|__ --|| _| _ || <| -__|__ --|
|_____||____|_____||__|__|_____|_____|
.----------------------------------.
( ajs(a)redhat.com || 919.754.4187 )
`----------------------------------'