On 12/01/10 00:43, Perry Myers wrote:
> On 12/01/2010 01:38 AM, Chris Feist wrote:
>> On 11/30/10 23:20, Perry Myers wrote:
>>
>>>> +<!-- What is the point of search_* methods?
>>>> + output is list of tupples:
>>>> + { filename (String), last_modified (Integer) }
>>>> +
https://fedorahosted.org/matahari/wiki/LoggingAPIs
>>>> + It's not part of Ricci API which is used as justification
>>>> +
http://sources.redhat.com/cluster/conga/ricci_api/logging_api.html
>>>
>>> Chris/Ryan, can you guys comment here?
>>
>> In ricci you can pass a set of paths to read logfiles from, in matahari it
>> looks like the functions require you to specify a filename. Using the
>> search_context or search_name functions in matahari will let you find all
>> the files in a path, and then use those filenames to pull data out.
>
> Couldn't we just do the same thing by allowing the extract_date_range and
> extract_pattern methods accept regexps or globs in the filename argument?
>
> Seems like that would be a more elegant solution (making the 2 API calls more
> flexible vs. providing 2 additional API calls)
That makes sense to me and would more closely mirror what the ricci logging module does.