On May 26, 2010, at 3:43 PM, Darryl L. Pierce wrote:
On Wed, May 26, 2010 at 09:23:44AM +0200, Andrew Beekhof wrote:
> Some quick questions...
>
> Is the interval not being used yet? I don't see any timers or such.
Not implemented yet. This patch just introduces the actual heartbeat event over QMF.
Ah, ok.
> Wouldn't you still need to update the network devices in Host::update()?
Those are going to get refactored. As it stands they weren't being updated.
'k
> Does the heartbeat event need a counter (like ICMP packets do) to
> detect backward jumps and/or lost heartbeats?
Right now the heartbeat sends out the timestamp. But if the clock gets changed, it
could seem to be a backwards jump. Changing it to be a counter instead would
be a simple change to this patch for pushing.
I think you'd probably want both. The timestamp and a sequence number.
-- Andrew