On Tue, May 3, 2011 at 4:21 PM, Radek Novacek <rnovacek(a)redhat.com> wrote:
On Monday 02 of May 2011 09:53:46 Andrew Beekhof wrote:
> Looks good. ACK.
>
> Btw. It looks like some configure checks are missing:
>
> ../lib/libmcommon_dbus.so.0.0.1: undefined reference to
> `polkit_authority_get_sync'
>
> Has the polkit API changed recently?
>
>
> Can we also have DBus support default to "try"?
> Ie. only fail during configure if all the dbus pieces aren't available
> _and_ it was explicitly requested.
Good idea. But we need to handle the case when someone want to disable DBus
explicitly. Unfortunately CMake option command supports only ON/OFF states (no
TRY).
What about a string argument instead of a boolean?
We might add another option, something like USE-DBUS, FORCE-DBUS.
CMAKE_DEPENDENT_OPTION [1] might be also useful (FORCE-DBUS only when USE-DBUS
is ON).
Usecases with this solution:
1) Disable DBus explicitly:
USE-DBUS = OFF
2) "try" [default]
USE-DBUS = ON
FORCE-DBUS = OFF
3) fail without DBus (e.g. in specfile)
USE-DBUS = ON
FORCE-DBUS = ON
Do you have better idea how to do it? Or better names for the options?
> I'll do the same for QMF.
Same two options will be needed for QMF.
Radek Novacek
[1]
http://www.cmake.org/cmake/help/cmake-2-8-
docs.html#module:CMakeDependentOption