On 08/11/11 11:23, Radek Novacek wrote:
diff --git a/src/lib/mh_dbus_common.c b/src/lib/mh_dbus_common.c
index 2e3a3a5..3e9e864 100644
--- a/src/lib/mh_dbus_common.c
+++ b/src/lib/mh_dbus_common.c
@@ -26,6 +26,7 @@
#include "matahari/logging.h"
#include "matahari/mainloop.h"
#include "matahari/errors.h"
+#include "matahari/mainloop.h"
#include<glib/gi18n.h>
#include<polkit/polkit.h>
@@ -163,7 +164,7 @@ run_dbus_server(char *bus_name, char *object_path)
DBusGProxy *driver_proxy = NULL;
guint32 request_name_ret;
- mh_log_init(bus_name, LOG_DEBUG, FALSE);
+ mh_log_init(bus_name, LOG_DEBUG, TRUE);
loop = g_main_loop_new(NULL, FALSE);
I'm not sure about this one. I would have thought that for DBus agents
we would (almost) always want to log to syslog rather than stderr? Or at
least do what we do in the QMF agents now (log to stderr iff it is
connected to a console).
Note that logging to stderr will end up putting stuff in the syslog when
run as a daemon, but only on systems with systemd.
Other than that, ACK to this whole series. Thanks Radek!
cheers,
Zane.