Jeremy Katz wrote:
On Sat, 2007-07-21 at 22:34 -0500, Douglas McClendon wrote:
> Changes from prior patch-
>
> - removed --container-size option, not really worthwhile
> - made cleanupDeleted default, revert to old behavior with --ignore-deleted
> - find minimal resize2fs size using a binary search accurate to the smallest
> possible blocksize
> - removed cp --sparse=always pass. not really worthwhile
> - added -y to e2fsck so that redirecting output didn't cause it to fail
Okay, this looks good at this point and doing it by default definitely
feels like the right thing. Would be nice if the filesystem were
smarter, though, as this is kind of ugly to have to do. Or at least if
resize2fs had a minimal mode. Can you file something in bugzilla
against e2fsprogs for the latter (feel free to cc me)?
The thought had occurred to me. Actually I went so far as to look at the
e2fsprogs code, to see if it wasn't really simple to add. What I discovered was
that there are several places (not just one) where it discovers that it is too
small (for varying reasons) and throws up an error. But yeah, I'll go ahead and
file a bug.
-dmc