Hi Gris,
I completed my review and added some more comments. I found some memory
leaks and potential for some memory leaks, please look them over.
Thanks,
Tony
On 04/20/2015 06:04 PM, Tony Asleson wrote:
Hi Gris,
Patch set looks pretty good, please see my comments thus far on github.
Disclaimer, I ran out of time while reviewing, will review more tomorrow.
Thanks,
Tony
On 04/18/2015 06:23 AM, Gris Ge wrote:
> * Putting two patch sets into one. As `pool_raid_info()` patch set is
> just preparation for `volume_create_raid()` patch set. It's better to explain
> design choice with both.
>
> * New method `pool_raid_info()` to query pool member information:
> * RAID type
> * Member type: disk RAID pool or sub-pool.
> * Members: disks or parent pools.
>
> * New method `volume_create_raid()` to create RAID group volume.
>
> * New method `volume_create_raid_cap_get()` to query RAID group volume create
> supported RAID type and strip sizes.
>
> * Design notes:
> * Why we need pool_raid_info() when we already have volume_raid_info()?
> The `pool_raid_info()` is focus on RAID disk or sub-pool layout.
>
> The `volume_raid_info()` is focus on providing information about host
> I/O performance and availability(raid).
>
> * Why don't create single sharable method for SAN/NAS/DAS about RAID
> creation?
> Please refer to design note of patch 'New feature: Create RAID volume
> on hardware RAID.'
>
> * Why no RAID creation method for SAN and NAS?
> As we tried before, due to complex RAID settings of SAN and NAS
> storage, I didn't find a simple design to support all of them.
>
> * Please refer to design note of patch 'New feature: Create RAID volume'
> also.
>
_______________________________________________
libstoragemgmt-devel mailing list
libstoragemgmt-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/libstoragemgmt-devel