On 04/23/2015 02:30 AM, Gris Ge wrote:
On Wed, Apr 22, 2015 at 10:31:49AM -0500, Tony Asleson wrote:
> Hi Gris,
>
> Please update the commit messages to reflect the name changes, eg.
> change pool_raid_info to pool_member_info etc.
>
> Thanks,
> -Tony
Hi Tony,
V5 patch set uploaded in github pull request with correct commit
messages now.
Hi Gris,
I was taking a quick peek over the latest commits in your branch before
I merged... and I found the following:
* lsm_plugin_ipc.cpp (1034): Memory leak, member_ids not being freed
I don't remember if I mentioned this before and I can't seem to figure
out how to find the previous line comments at github. I may be placing
code comments in emails again for historical reference, unless there is
a way to do this in github that I am missing :-/ Andy pointed me to:
https://julien.danjou.info/blog/2013/rant-about-github-pull-request-workf...
I found this, which I think I missed the first time, sorry:
* lsm_convert.cpp (626): We should zero the count and null the array
pointer, otherwise if we throw the exception on line 626 we could have a
count != 0 and try to free memory that we didn't allocate.
I didn't email these patches to maillist since they are purely
commit
message changes and a trivial code comment update.
Yes, this is fine
Regards,
Tony