On 23/11/22 7:11 pm, Philipp Rudo wrote:
Thanks for the review.
just one question.
On Mon, 21 Nov 2022 18:56:08 +0530
Hari Bathini <hbathini(a)linux.ibm.com> wrote:
> With kernel commit 607451ce0aa9b ("powerpc/fadump: register for fadump
> as early as possible"), 'kdumpctl start' prematurely returns with the
This patch also disables the check for kernels without the commit
mentioned. Is that intended? If that's the case
yeah, that should be fine as kernel commit 0823c68b054b
("powerpc/fadump: re-register firmware-assisted dump if already
registered") to cover for that case..
> Reviewed-by: Philipp Rudo <prudo(a)redhat.com>
>> below message:
>> "Kdump already running: [WARNING]"
>> instead of setting default initrd with dump capture capability as
>> required for fadump. Skip status check in fadump mode to avoid this
>> Signed-off-by: Hari Bathini <hbathini(a)linux.ibm.com>
>> kdumpctl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/kdumpctl b/kdumpctl
>> index 03c91f3..d6fb7bd 100755
>> --- a/kdumpctl
>> +++ b/kdumpctl
>> @@ -1059,7 +1059,7 @@ start()
>> return 1
>> - if check_current_status; then
>> + if [[ $DEFAULT_DUMP_MODE == "kdump" ]] &&
>> dwarn "Kdump already running: [WARNING]"
>> return 0