With kernel commit 607451ce0aa9b ("powerpc/fadump: register for fadump as early as possible"), 'kdumpctl start' prematurely returns with the below message:
"Kdump already running: [WARNING]"
instead of setting default initrd with dump capture capability as required for fadump. Skip status check in fadump mode to avoid this problem.
Signed-off-by: Hari Bathini hbathini@linux.ibm.com --- kdumpctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl index 03c91f3..d6fb7bd 100755 --- a/kdumpctl +++ b/kdumpctl @@ -1059,7 +1059,7 @@ start() return 1 fi
- if check_current_status; then + if [[ $DEFAULT_DUMP_MODE == "kdump" ]] && check_current_kdump_status; then dwarn "Kdump already running: [WARNING]" return 0 fi
Hi Hari,
just one question.
On Mon, 21 Nov 2022 18:56:08 +0530 Hari Bathini hbathini@linux.ibm.com wrote:
With kernel commit 607451ce0aa9b ("powerpc/fadump: register for fadump as early as possible"), 'kdumpctl start' prematurely returns with the
This patch also disables the check for kernels without the commit mentioned. Is that intended? If that's the case
Reviewed-by: Philipp Rudo prudo@redhat.com
below message:
"Kdump already running: [WARNING]"instead of setting default initrd with dump capture capability as required for fadump. Skip status check in fadump mode to avoid this problem.
Signed-off-by: Hari Bathini hbathini@linux.ibm.com
kdumpctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl index 03c91f3..d6fb7bd 100755 --- a/kdumpctl +++ b/kdumpctl @@ -1059,7 +1059,7 @@ start() return 1 fi
- if check_current_status; then
- if [[ $DEFAULT_DUMP_MODE == "kdump" ]] && check_current_kdump_status; then dwarn "Kdump already running: [WARNING]" return 0 fi
On 23/11/22 7:11 pm, Philipp Rudo wrote:
Hi Hari,
Hi Philipp,
Thanks for the review.
just one question.
On Mon, 21 Nov 2022 18:56:08 +0530 Hari Bathini hbathini@linux.ibm.com wrote:
With kernel commit 607451ce0aa9b ("powerpc/fadump: register for fadump as early as possible"), 'kdumpctl start' prematurely returns with the
This patch also disables the check for kernels without the commit mentioned. Is that intended? If that's the case
yeah, that should be fine as kernel commit 0823c68b054b ("powerpc/fadump: re-register firmware-assisted dump if already registered") to cover for that case..
- Hari
Reviewed-by: Philipp Rudo prudo@redhat.com
below message:
"Kdump already running: [WARNING]"instead of setting default initrd with dump capture capability as required for fadump. Skip status check in fadump mode to avoid this problem.
Signed-off-by: Hari Bathini hbathini@linux.ibm.com
kdumpctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl index 03c91f3..d6fb7bd 100755 --- a/kdumpctl +++ b/kdumpctl @@ -1059,7 +1059,7 @@ start() return 1 fi
- if check_current_status; then
- if [[ $DEFAULT_DUMP_MODE == "kdump" ]] && check_current_kdump_status; then dwarn "Kdump already running: [WARNING]" return 0 fi
Patch merged, thanks to Hari and Philipp!
On Mon, Nov 21, 2022 at 06:56:08PM +0530, Hari Bathini wrote:
With kernel commit 607451ce0aa9b ("powerpc/fadump: register for fadump as early as possible"), 'kdumpctl start' prematurely returns with the below message:
"Kdump already running: [WARNING]"
instead of setting default initrd with dump capture capability as required for fadump. Skip status check in fadump mode to avoid this problem.
Signed-off-by: Hari Bathini hbathini@linux.ibm.com
kdumpctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl index 03c91f3..d6fb7bd 100755 --- a/kdumpctl +++ b/kdumpctl @@ -1059,7 +1059,7 @@ start() return 1 fi
- if check_current_status; then
- if [[ $DEFAULT_DUMP_MODE == "kdump" ]] && check_current_kdump_status; then dwarn "Kdump already running: [WARNING]" return 0 fi
-- 2.38.1 _______________________________________________ kexec mailing list -- kexec@lists.fedoraproject.org To unsubscribe send an email to kexec-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
-
Coiby Xu -
Hari Bathini -
Philipp Rudo