On Mon, May 22, 2023 at 03:40:39PM +0200, Philipp Rudo wrote:
Hi Coiby,
On Wed, 17 May 2023 18:20:34 +0800
Coiby Xu <coxu(a)redhat.com> wrote:
[...]
> >> + Describe "When kexec-tools have its default crashkernel updated,
"
> >> +
> >> + BeforeAll 'setup'
> >> + AfterAll 'cleanup'
> >> +
> >> + Context "if kexec-tools is updated alone, "
> >> + Specify 'reset_crashkernel_after_update should report updated
kernels and note that auto_reset_crashkernel=yes'
> >> + When call reset_crashkernel_after_update
> >> + The output should include "For kernel=$kernel1,
crashkernel=$kdump_crashkernel now."
> >> + The output should not include "For kernel=$kernel2,
crashkernel=$kdump_crashkernel now."
> >> + The output should include "auto_reset_crashkernel=no"
> >
> >I find the last check quite confusing. First I thought that you return
> >the value auto_reset_crashkernel is set to. But it is only a hint on
> >how to turn off the auto update. Personally I would simply remove the
> >line.
>
> Sorry it confuses you. Personally, I think we should let users know this
> hint otherwise users may complain somehow there custom crasherkernel
> doesn't persist. How about adding a comment to explain it?
No problem. I agree that having the note makes sense. But personally I
don't think it's important enough to add a test case for it. Anyway, if
you add a short comment I'm fine with keeping it.
BTW, I've noticed that you are simply echo'ing the line you are
checking for here. Is that intended? Wouldn't dinfo make more sense, so
users can silence the message if they desire.
Yeah, I used echo because 1) dinfo somehow fails the unit tests 2) it's
easy to use echo to print two messages (I split the long message into
two lines for the sake of code readability) as one line. I've mocked
dinfo and use += to concatenate two messages in order to reap the
benefit of allow users to silence the message in v2. Thanks!
Thanks
Philipp
_______________________________________________
kexec mailing list -- kexec(a)lists.fedoraproject.org
To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
--
Best regards,
Coiby