On 12/6/23 17:11, Philipp Rudo wrote:
For the series
Reviewed-by: Philipp Rudo <prudo(a)redhat.com>
Thanks a lot, Philipp.
Happy New Year.
Hopefully I haven't missed anything, but assuming
https://src.fedoraproject.org/rpms/kexec-tools/commits/rawhide would be the way
into Fedora Rawhide, I could not find commits yet corresponding to my patch
series (nor in
https://gitlab.com/redhat/centos-stream/rpms/kexec-tools).
My 2 patches do not depend on anything (new).
They are a pre-req for some of the other pending pull requests for other packages.
What can I do to get the kexec-tools patches into upstream/rawhide?
On Thu, 9 Nov 2023 16:50:38 +0100
Steffen Maier <maier(a)linux.ibm.com> wrote:
> Consolidate the persistent and dynamic configuration of s390-specific
> network devices by delegating the configuration to the existing framework
> zdev from s390-tools.
>
> This is part of a larger consolidation comprising:
>
https://github.com/ibm-s390-linux/s390-tools/pull/158
>
https://github.com/dracutdevs/dracut/pull/2534
>
https://github.com/storaged-project/blivet/pull/1162
>
https://github.com/rhinstaller/anaconda/pull/5250
>
https://github.com/steffen-maier/s390utils/pull/1
> However, there are no dependencies on these other pull requests, so the
> change here can go in independently. It only depends on zdev from
> s390-tools, which exists since years.
>
> Zdev's job is to perform low-level configuration after which the user gets
> architecture-independent objects such as network interfaces. Those can and
> should in turn be configured with existing common code mechanisms. So
> there's a clear separated layering for configuration duties.
>
> In particular, the s390-specific network devices currently are: ZNET
> representing channel-attached network (QETH incl. OSA and HiperSockets,
> LCS, CTC). Zdev has a stable command line user interface and abstracts from
> sysfs and from a persistent configuration representation. Zdev encapsulates
> configuration details. Systems management code can simply delegate
> configuration to zdev and thus reduce architecture-specific code.
>
> This improves user experience, serviceability, maintainability, and reduces
> test effort.
>
> Changes since v1:
> Addressed review comments from Philipp:
> * Replaced first paragraph (dracut commit reference) of patch 1 description
> with a summary of this cover letter providing URLs to 2 pull requests
> for dracut and s390utils with relevant commit titles.
> * Put temp file under subdir ${_DRACUT_KDUMP_NM_TMP_DIR}.
> My own changes:
> * Patch 2 description now also references the s390utils pull request
> with relevant commit title to provide further information regarding
> migration of znet persistent config from the old to the new scheme.
>
> Steffen Maier (2):
> dracut-module-setup: consolidate s390 network device config (#1937048)
> dracut-module-setup: remove old s390 network device config (#1937048)
>
> dracut-module-setup.sh | 53 ++++++++++++++----------------------------
> 1 file changed, 17 insertions(+), 36 deletions(-)
>
>
> base-commit: 5058cef90c2e24ff3a17a9c5560e16363e3281f5
--
_______________________________________________
kexec mailing list -- kexec(a)lists.fedoraproject.org
To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z and LinuxONE
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschaeftsfuehrung: David Faller
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294