On 03/05/14 at 03:30pm, Jerry Hoemann wrote:
On Mon, Mar 03, 2014 at 06:37:16PM +0800, Baoquan He wrote:
> kdump now dumps vmcore to root partition by default in SAVE_PATCH
> directory, e.g /var/crash defaultly. This is problematic when another
> disk is mounted on /var or /var/crash, because the saved vmcore will
> he hidden after dump in 1st kernel. This also has the potential of
> blindly filling the root file system without a clue as to why.
>
> Now fix this by failing the loading of kdump kernel if dump target
> is root fs by default while different disk is mounted on save path.
>
> Signed-off-by: Baoquan He <bhe(a)redhat.com>
> ---
> mkdumprd | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
--
Baoquan,
Thanks for making this change. I have hit this problem and this
modification will make things better.
This got me thinking about the issue, and I have an idea
for a next step and wanted your feedback.
Right now, fedora requires the pair { <partition>, <path> }
where path is relative to the root of the partition.
I find this a little confusing especially when using the gui
system-config-kdump.
As an alternative, could we instead of having the customer visible
entities that need to be configured as the above pair, could we
just have them specify the mounted path and walk up the path
to find the partition?
So, if they say "/home/user/crash" we first look if
"/home/user/crash"
is a mounted partition, if it is, this is the partition for crash
and our relative path is ".".
If crash isn't a mounted partition we check "/home/user" and if it is our
partition is that and the relative path is "./crash". And so on until
we get to "/".
As a proof of concept, I wrote a script to decompose a "path" into
the deepest mounted partition and relative offset, but wanted to get
your and Vivek's views before i continued down this road.
Hi Jerry,
Thanks for your great idea. I remember we thought about this during
cleaning the concept of "default target", "default action" and
"default
default action". But we didn't go that deep as you thought of.
Actually what you mentioned is just like a kernel intelnal function
path_lookup(), right? Each time when I go through this function, a
shiver ran down my body. It's too complicated. As for kdump script, the
path and partition concept has embedded into user's heart, and in a shell
script this solution may mess up the code, it's not good to maintain and
read.
This is just my personal opinion. I also want to see how other people
think of this.
Baoquan
Thanks
thanks
Jerry
----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett-Packard
3404 E Harmony Rd. MS 57 phone: (970) 898-1022
Ft. Collins, CO 80528 FAX: (970) 898-XXXX
email: jerry.hoemann(a)hp.com
----------------------------------------------------------------------------
_______________________________________________
kexec mailing list
kexec(a)lists.fedoraproject.org
https://lists.fedoraproject.org/mailman/listinfo/kexec