Hi Hari,
On Mon, Nov 14, 2022 at 3:13 PM Hari Bathini <hbathini(a)linux.ibm.com> wrote:
On 12/11/22 8:03 am, Tao Liu wrote:
> Hi Hari
>
> On Fri, Nov 11, 2022 at 10:43 PM Hari Bathini <hbathini(a)linux.ibm.com> wrote:
>>
>> If available, use 'zstd' compression method to optimize size of the
>> initramfs built with fadump support.
>>
>> Signed-off-by: Hari Bathini <hbathini(a)linux.ibm.com>
>> ---
>> mkfadumprd | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/mkfadumprd b/mkfadumprd
>> index 36ad645..2fc396c 100644
>> --- a/mkfadumprd
>> +++ b/mkfadumprd
>> @@ -62,11 +62,9 @@ _dracut_isolate_args=(
>> /usr/lib/dracut/fadump-kernel-modules.txt
>> )
>>
>> -# Same as setting zstd in mkdumprd
>> +# Use zstd compression method, if available
>> if ! have_compression_in_dracut_args; then
>> - if is_squash_available && dracut_have_option
"--squash-compressor"; then
>> - _dracut_isolate_args+=(--squash-compressor zstd)
>> - elif is_zstd_command_available; then
>
> I didn't understand why only consider the case of zstd cmd, don't we
> use zstd format squashfs for the fadump case? If possible, could you
> please append the reason at the commit log for future reference?
Observed better space optimization with zstd instead of squash+zstd
most likely due to the additional binary requirement for squash case..
OK, thanks for the clarification!
Thanks,
Tao Liu
Thanks
Hari