Hi Philipp,
I find this patch set fails the unit tests. Can you fix the test
failures? Thanks!
[root@08f80338bc07 kexec-tools-fed]# shellspec
Running: /bin/sh [bash 5.2.2(1)-release]
.........................................................................................................................FFFFFFFFFF........FF.FF.FF.FFFFF.FF.FFFFF.FF.FFF.
Examples:
1) kdumpctl _update_kernel_arg_in_grub_etc_default() when the given parameter is in
different positions should update the kernel parameter correctly
When call _update_kernel_arg_in_grub_etc_default crashkernel 333M
1.1) The contents of file /tmp/default_grub should include
crashkernel=333M"
expected "GRUB_CMDLINE_LINUX="crashkernel=222M fadump=on rhgb
quiet"" to include "crashkernel=333M""
# spec/kdumpctl_general_spec.sh:179
...
Finished in 8.36 seconds (user 4.66 seconds, sys 6.13 seconds)
170 examples, 33 failures
On Thu, Aug 31, 2023 at 04:02:55PM +0200, Philipp Rudo wrote:
Hi everybody,
this series got spit from the CLI rework series as they are independent and can
be merged earlier to reduce the overall series size. While most of the patches
were part of the rfc v1 of the CLI rework series patches 9-13 are new.
Thanks
Philipp
v1 -> v2
- Added new patch 13, which I've noticed during reviewing the patch Coiby
posted to split up the package.
- Improved the commit message of patch 10 with comments from Pingfan.
- Added Pingfan's Reviewed-by to all patches contained in v1.
rfc -> v1:
- Rebased to latest rawhide
- Patch 1 added two more fixes.
- Patch 2,4&8 improved the commit message
- Patch 3 dropped definition of _is_valid_kver as it was already present on
latest rawhide
- Added new patches 9-12
Philipp Rudo (13):
Fix various shellcheck findings
kdump-lib: make is_zstd_command_available more generic
kdump-lib: simplify _get_kdump_kernel_version
kdumpctl: drop _get_current_running_kernel_path
kdumpctl: drop condrestart subcommand
kdumpctl: simplify _update_kernel_cmdline
kdumpctl: Prevent option --fadump on non-PPC in reset_crashkernel
kdumpctl: Stop updating grub config in reset_crashkernel
kdump.conf: Remove option override_resettable
spec: Clean up handling of dracut files
spec: Silence unversioned Obsolete warning
kdump-lib: Harden _crashkernel_add
spec: Drop special handling for IA64 machines
gen-kdump-conf.sh | 6 --
kdump-lib.sh | 179 +++++++++++++++++++++----------
kdump.conf.5 | 8 --
kdumpctl | 236 +++++++++++++----------------------------
kexec-tools.spec | 72 ++++---------
mkdumprd | 57 +---------
mkfadumprd | 2 +-
spec/kdump-lib_spec.sh | 38 ++++---
8 files changed, 237 insertions(+), 361 deletions(-)
--
2.41.0
--
Best regards,
Coiby