On 05/11/16 at 02:50pm, Dave Young wrote:
Hi, Pratyush
Since Baoquan is still reviewing it, I will hold on to merge this series,
will wait until he finished the review.
Hi Dave,
I have acked this series in my latest comments. It may contain too many
sentences so that the ack is not apparent. So feel free to merge it.
Thanks
Baoquan
>
> Thanks
> Dave
>
> On 05/10/16 at 10:19am, Xunlei Pang wrote:
> > On 2016/05/09 at 16:17, Pratyush Anand wrote:
> > > Kexec-tools should be able to recognize if a dump target is reformatted,
or
> > > dump path mounts another device.
> > >
> > > Changes since v5:
> > > - Commit log improved
> > > - is_xxxx_modified() has been renamed as check_xxxx_modified(), because it
> > > is returning non-boolean values.
> > > - check_dump_fs_modified() logic has been simplified.
> > >
> > > Changes since v5:
> > > - Couple of spellcheck in comments
> > > - name convert for $_target while discovering $_fstype
> > > - an extra "grep $_id" when dracut argument has
"by-uuid"
> > > - No need to check if ssh/nfs/raw target is specified. We will fix such
> > > cases latter by introducing separate checks for them
> > >
> > > Changes since v4:
> > > - patch 4/5 is a new change
> > > - patch 4/4 of V3 is now 4/5. There has been many modifications in this
> > > patch. It includes feedback from Baoquan and Xunlei. Have also done some
> > > modification to recognize changes related to minix and NFS filesystem as
> > > well. Infact, whole structure of function is_fs_uuid_changed() has been
> > > modified. Now it has been renamed as is_dump_fs_modified() to suit it
> > > better. Although I have tested it rigorously, but still a careful review
> > > of is_dump_fs_modified() will be helpful.
> > >
> > > Changes since v3:
> > > - "$ret" unquoted
> > > - No message for "$system_modified" != "0"
> > > - image_time is now global
> > > - is_dump_target_modified has been renamed as is_fs_uuid_changed
> > >
> > > Changes since v2:
> > > -- now is_system_modified returns 2 in case of invalid modification, 1 in
> > > case of valid modification and 0 in case of no modification.
> > > -- file modification check has been moved to is_system_modified now
> > > -- variables have been put under "" in if condition check
> > >
> > > Changes since v1:
> > > -- Local variable is defined in shell function now
> > > -- raw target does not take persistent names "by-uuid" now
> > > -- dracut arguments grep is more robust
> > > -- When no UUID then warn and return
> > >
> > > Pratyush Anand (5):
> > > mkdumprd: do not lookup in by-uuid dirs for raw device's persistent
> > > name
> > > kdumpctl: force rebuild in case of dynamic system modification
> > > kdumpctl: Move file modification check logic in
> > > check_system_modified()
> > > mkdumprd: move to_dev_name() & get_persistent_dev() to kdump-lib.sh
> > > kdumpctl: force rebuild in case of file system is modified
> > >
> > > kdump-lib.sh | 49 ++++++++++++++++++++
> > > kdumpctl | 144
++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
> > > mkdumprd | 47 +------------------
> > > 3 files changed, 188 insertions(+), 52 deletions(-)
> > >
> >
> > For the series,
> > Acked-by: Xunlei Pang <xlpang(a)redhat.com>
> > _______________________________________________
> > kexec mailing list
> > kexec(a)lists.fedoraproject.org
> >
http://lists.fedoraproject.org/admin/lists/kexec@lists.fedoraproject.org