On 06/15/16 at 02:46pm, Xunlei Pang wrote:
On 2016/06/15 at 14:15, Dave Young wrote:
>> From "man nfs" : The fstype field contains "nfs". Use of
the "nfs4" fstype in /etc/fstab is deprecated.
>> So I guess we can add all related ko modules for "nfs" fstype here,
like the patch below?
>>
>> for i in $(host_fs_all); do
>> + if [[ $i = nfs ]]; then
>> + # From "man nfs": The fstype field contains
"nfs". Use of the "nfs4" fstype in /etc/fstab is deprecated.
>> + # For "nfs" fstype, we better install all the
possible ko modules(from 95nfs/module-setup.sh installkernel).
>> + i="nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl
nfs_layout_nfsv41_files"
>> + elif [[ $i = nfs[3-4] ]]; then
>> + # For example, map nfs4 to use nfsv4.ko
>> + i=${i/nfs/nfsv}
>> + fi
> It sounds good, just wonder if it can be improved by something like
> instmods =fs/nfs for all the nfs modules in the if section. Not tested,
> just a guess..
This is cool, it works. I'll try to make a dracut patch.
Glad to see it work
:)
BTW: I remembered we don't need to open a dracut bug upstream,
but we still need a RHEL7 dracut bug, am I correct?
Yes, we need one..
>
> >> hostonly='' instmods $i
> >> done
> >>
> >>
> >> Or, if it is not acceptable on dracut's side, we can add
"--add-drivers" for "nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl
nfs_layout_nfsv41_files"
> >> in kdump code in this patch like that in the early versions, any comment?
> > It looks very odd actually :(
>
> Yes, that's why I removed it in the following versions.
>
> Regards,
> Xunlei
>
> >
> > Thanks
> > Dave
>