Hi Pingfan,
with the ShellCheck findings in patch 2 fixed the series looks good to
me. But it would be better if someone else could have a look at the
first two patches as well as they are basically from me. Anyway
Reviewed-by: Philipp Rudo <prudo(a)redhat.com>
There's an other problem I found in reset_crashkernel which is somehow
related to this series. In particular reset_crashkernel assumes that
there is a single crashkernel= value we use for all non-ppc
arches. But that is no longer true for aarch64 now as we can have both
kernel variants installed. I've got a fix for that in my series which I
can hopefully post later this week (still need to do some testing...).
So just a heads up.
Thanks
Philipp
On Mon, 29 May 2023 18:02:41 +0800
Pingfan Liu <piliu(a)redhat.com> wrote:
6k aarch64 has significant memory consumption more than 4k variant,
and
requires an separated crashkernel formula.
This series generates the formula dynamiclly based on the system
environment.
---
v3 -> v4
Introduce parse_kver_from_path() to extract kernel version info
Simplify bash return statement
Pingfan Liu (4):
kdump-lib: Introduce a help function _crashkernel_add()
kdump-lib: Introduce parse_kver_from_path() to get kernel version from
its path name
kdump-lib: add support for 64K aarch64
kdump-lib: Evaluate the memory consumption by smmu and mlx5 separately
kdump-lib.sh | 138 ++++++++++++++++++++++++++++++++++++++++-
kdumpctl | 6 +-
spec/kdump-lib_spec.sh | 20 ++++++
3 files changed, 161 insertions(+), 3 deletions(-)