On 12/11/15 at 02:02pm, Dave Young wrote:
On 12/11/15 at 01:51pm, Minfei Huang wrote:
> On 12/11/15 at 01:39pm, Dave Young wrote:
> > On 12/11/15 at 01:19pm, Minfei Huang wrote:
> > > Hi, Dave.
> > >
> > > I am fine with this patch. It is more appropriate if you can add the
> > > comment log that systemd will umount device to avoid data corruption.
> > >
> > > Thanks
> > > Minfei
> > >
> > > On 12/09/15 at 04:02pm, Dave Young wrote:
> > > > Systemd reports a conflict when kdump calls reboot during booting
> > > > because it tries to stop services while they are starting up.
> > > >
> > > > use systemctl reboot -f will fix this problem.
> > > >
> > > > man systemd.service show below:
> > > >
> > > > [snip]
> > > > reboot causes a reboot
> > > > following the normal shutdown procedure (i.e. equivalent to
systemctl reboot). reboot-force causes a forced reboot
> > > > which will terminate all processes forcibly but should cause no
dirty file systems on reboot (i.e. equivalent to
> > > > systemctl reboot -f) and reboot-immediate causes immediate execution
of the reboot(2) system call, which might result in
> > > > data loss.
> > > > [snip]
> >
> > Above is the systemd documentation you mentioned,
> > -f means reboot-force
> > -f -f means reboot-immediate
> >
>
> Yes. Here is manpage from my PC.
>
> When used with halt, poweroff, reboot or kexec, execute the selected
> operation without shutting down all units. However, all processes will
> be killed forcibly and all file systems are unmounted or remounted
> read-only.
>
> I think it can explain why ext2 doesn't be corrupted by "systemctl
> reboot -f".
Yes, I have updated the patch, but I will explain it and refer to manpage
instead of copy them word by word.
It is fine, if the patch log mentions the reason.
I choose ext2 to test because journal filesystems is not obvious to check
if it is diry or not.
Yes. Ext2 is the best choice to verify it.
Thanks
Minfei