On Wed, Sep 13, 2023 at 02:55:07PM +0200, Philipp Rudo wrote:
Hi Coiby,
On Wed, 13 Sep 2023 15:41:02 +0800
Coiby Xu <coxu(a)redhat.com> wrote:
> Hi Philipp,
>
>
> On Wed, Sep 06, 2023 at 10:49:50AM +0200, Philipp Rudo wrote:
> >In the BLS config files the paths provided for the kernel image and
> >initrd have to be relative to the boot partition. Thus drop the
> >additional /boot. Otherwise the test case fails during setup with
> >
> > The param /boot/vmlinuz-5.14.14-200.fc34.x86_64 is incorrect
>
> Could you share how to reproduce this failure? Actually, I tried running
> the unit tests on both f36, f37 and f38, and the results are the same,
I didn't need to do anything special to reproduce it. The only thing
you need to take care that you need a separate /boot partition. But
AFAIK that is the default for Fedora. At least all my systems have it
and also a freshly installed beaker system gave me
# lsblk
NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINTS
sda 8:0 0 408.4G 0 disk
├─sda1 8:1 0 1M 0 part
├─sda2 8:2 0 1G 0 part /boot
└─sda3 8:3 0 407.4G 0 part /home
/
sr0 11:0 1 1024M 0 rom
zram0 252:0 0 8G 0 disk [SWAP]
# cat /boot/loader/entries/7d97a6071bd4447894f40ac8ab27e8f6-6.4.15-200.fc38.x86_64.conf
title Fedora Linux (6.4.15-200.fc38.x86_64) 38 (Thirty Eight)
version 6.4.15-200.fc38.x86_64
linux /vmlinuz-6.4.15-200.fc38.x86_64
initrd /initramfs-6.4.15-200.fc38.x86_64.img
[...]
> 1. with this final patch applied, there will be unit test failures
> because some of the test cases check if the error include the path of
> kernel path, e.g.
>
> 8) kdumpctl reset-crashkernel [--kernel] [--fadump] FADump Switch between
fadump=on and fadump=nocma fadump=nocma to fadump=on
> When call reset_crashkernel --kernel=ALL --fadump=on
>
> 8.1) The error should include Updated fadump=on for
kernel=/boot/vmlinuz-5.15.6-100.fc34.x86_64
>
> expected "kdump: Updated fadump=on for
kernel=/vmlinuz-5.15.6-100.fc34.x86_64. Please reboot the system for the change to take
effect.
> kdump: Updated fadump=on for kernel=/vmlinuz-5.14.14-200.fc34.x86_64.
Please reboot the system for the change to take effect.
> kdump: Updated fadump=on for
kernel=/vmlinuz-0-rescue-e986846f63134c7295458cf36300ba5b. Please reboot the system for
the change to take effect." to include "Updated fadump=on for
kernel=/boot/vmlinuz-5.15.6-100.fc34.x86_64"
When I ran the tests before posting all the tests were green. And if I
understand the grubby code correctly it shouldn't be a problem as it
adds the prefix, aka. the boot partition, again when it prints the
kernel image to stdout.
Thanks for the provided details, I now found the difference is if a boot
partition exists. Because these tests were added by me, I feel I should be
responsible for that. So I've sent an patch '"[PATCH] unit tests: fix test
failures "The param /boot/boot/vmlinuz-xxx is incorrect"'.
Thanks
Philipp
>
> 2. without this patch, all unit tests have green status.
>
--
Best regards,
Coiby