On 5/10/22 04:31, Coiby Xu wrote:
Hi Dusty,
On Fri, May 06, 2022 at 10:08:56AM +0800, RuiRui Yang wrote:
> Hi Dusty,
>
> On Tue, 3 May 2022 at 22:43, Dusty Mabe <dusty(a)dustymabe.com> wrote:
>>
>> Hi Team,
>>
>> Editing /etc/sysconfig/kdump via something like `sed` is error prone and also
>> means I'll no longer get RPM updates to that file in the future. It would be
>> nice if we could have some sort of dropin configuration directly to override
>> default behavior (think systemd dropins) like a /etc/kdump.d/ directory.
>>
>> Has there been any considering for such a feature? Does it sound like a good
>> or bad idea?
>
> I would say if we have no strong reason to do that, for the "irqpoll"
> example we can just post a patch to change the default instead of
> depending on users to do extra overriding. But anyway this is up to
> the developers to decide, let's see how others think about it :)
I don't how much work we need to support config dropins. But if you have
the only use case of adding `ignition.firstboot` to the
`KDUMP_COMMANDLINE_REMOVE=`, I would suggest simply changing the default
/etc/sysconfig/kdump.
Yeah that's just one example. I'm sure there are others. For example for
https://bugzilla.redhat.com/show_bug.cgi?id=2080468 downstreams could put
in a config dropin to workaround that issue for now, rather than having to
use sed.
The config dropin model is very powerful (think systemd) and I think there
are some libraries that make it easy to use them. That being said, it is some
investment so it doesn't come for free.
Dusty