On Wed, Apr 12, 2023 at 04:23:14PM +0200, Philipp Rudo wrote:
On Wed, 12 Apr 2023 19:36:30 +0800
Coiby Xu <coxu(a)redhat.com> wrote:
> Relates:
https://bugzilla.redhat.com/show_bug.cgi?id=2151504
>
> Currently, when the network isn't ready, kdump would repeatedly print
> the same info,
>
> [ 29.537230] kdump[671]: Bad kdump network destination: 192.123.1.21
> [ 30.559418] kdump[679]: Bad kdump network destination: 192.123.1.21
> [ 31.580189] kdump[687]: Bad kdump network destination: 192.123.1.21
>
> This is not user-friendly and users may think kdump has got stuck. So
> also show much time has waited for the network to be ready,
>
> [ 29.546258] kdump[673]: Waiting for network to be ready (50s / 10min)
> ...
> [ 32.608967] kdump[697]: Waiting for network to be ready (56s / 10min)
>
> Note kdump_get_ip_route no longer prints an error message and it's up to
> the caller to determine the log level and print relevant messages. And
> kdump_collect_netif_usage aborts when kdump_get_ip_route fails.
>
> Reported-by: Martin Pitt <mpitt(a)redhat.com>
> Signed-off-by: Coiby Xu <coxu(a)redhat.com>
Looks good to me
Reviewed-by: Philipp Rudo <prudo(a)redhat.com>
The patch set has been merged, thanks!
--
Best regards,
Coiby