On 06/18/15 at 01:45pm, Minfei Huang wrote:
On 06/18/15 at 10:22am, Dave Young wrote:
> On 06/15/15 at 09:29pm, Minfei Huang wrote:
> > Now Kdump will ingore the DNS config in /etc/resolv.conf, when it
> > generates the initram. And most users do not concern about this issue,
> > because they never use deployment tools to configure machines
> > environment, like puppet.
> >
> > It is more convenient to add the DNS config to /etc/resolv.conf for
> > people who use deployment tools to configure machines concurrently.
> >
> > Signed-off-by: Minfei Huang <mhuang(a)redhat.com>
> > ---
> > dracut-module-setup.sh | 18 +++++++++++++++++-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> > index 73ab938..ad842b2 100755
> > --- a/dracut-module-setup.sh
> > +++ b/dracut-module-setup.sh
> > @@ -64,10 +64,26 @@ kdump_is_vlan() {
> >
> > # $1: netdev name
> > kdump_setup_dns() {
> > - _dnsfile=${initdir}/etc/cmdline.d/42dns.conf
> > + local _nameserver _dns
> > + local _dnsfile=${initdir}/etc/cmdline.d/42dns.conf
> > . /etc/sysconfig/network-scripts/ifcfg-$1
> > +
> > + touch $_dnsfile
>
> no need to touch it..
>
The warning will be raised, since we use "cat $_dnsfile" to echo the
content directly, without touching the $_dnsfile.
Ok, I will do the judgement before using "cat $_dnsfile".
Please repost with fix to above problem, since add duplicate dns record
is ok I will not object about the overall patch solution.
Thanks
Dave