Hi Philipp,
Glad to see these chores are done. They make the code neat.
I only have a minor disagreement on the commit log of [10/12].
For the rest of the series,
Reviewed-by: Pingfan Liu <piliu(a)redhat.com>
On Fri, Jul 21, 2023 at 10:24 PM Philipp Rudo <prudo(a)redhat.com> wrote:
Hi everybody,
this series got spit from the CLI rework series as they are independent and can
be merged earlier to reduce the overall series size. While most of the patches
were part of the rfc v1 of the CLI rework series patches 9-12 are new.
@Pingfan: I've dropped your Reviewed-by from patch 1 as I've added two more
fixes to the patch. But I've kept it for patch 2&4 where I've
updated
the commit message and patch 3 where I've dropped the definition of
_is_valid_kver as after the rebase an identical function already
existed. Hope that is ok with you.
To simplify review I've also pushed the series to branch cleanup on
https://src.fedoraproject.org/forks/prudo/rpms/kexec-tools.git.
Thanks
Philipp
rfc -> v1:
- Rebased to latest rawhide
- Patch 1 added two more fixes.
- Patch 2,4&8 improved the commit message
- Patch 3 dropped definition of _is_valid_kver as it was already present on
latest rawhide
- Added new patches 9-12
Philipp Rudo (12):
Fix various shellcheck findings
kdump-lib: make is_zstd_command_available more generic
kdump-lib: simplify _get_kdump_kernel_version
kdumpctl: drop _get_current_running_kernel_path
kdumpctl: drop condrestart subcommand
kdumpctl: simplify _update_kernel_cmdline
kdumpctl: Prevent option --fadump on non-PPC in reset_crashkernel
kdumpctl: Stop updating grub config in reset_crashkernel
kdump.conf: Remove option override_resettable
spec: Clean up handling of dracut files
spec: Silence unversioned Obsolete warning
kdump-lib: Harden _crashkernel_add
gen-kdump-conf.sh | 6 --
kdump-lib.sh | 175 ++++++++++++++++++++----------
kdump.conf.5 | 8 --
kdumpctl | 236 +++++++++++++----------------------------
kexec-tools.spec | 50 ++++-----
mkdumprd | 57 +---------
mkfadumprd | 2 +-
spec/kdump-lib_spec.sh | 38 ++++---
8 files changed, 235 insertions(+), 337 deletions(-)
--
2.40.0