On Tue, Jul 22, 2014 at 01:54:22PM +0800, WANG Chao wrote:
On 07/21/14 at 02:17pm, Vivek Goyal wrote:
> On Fri, Jul 18, 2014 at 04:14:04PM +0800, WANG Chao wrote:
> > This patch does the following change in 2nd kernel:
> > - dump target is mounted under /sysroot
> >
> > With this change, we don't need to track what we've mounted in 2nd
> > kernel. We can just umount recursively every mount in /sysroot by
> > command:
> >
> > umount -R /sysroot
> >
> > It's very convenient to do so, because it's hard to track what
we've
> > mounted when we're in error handling path. So mount everything under
> > /sysroot is reasonable and practical for us.
> >
> > Also clean up a bit along with this patch.
>
> So, shouldn't all the unmounting be done by systemd reboot path?
We're calling "reboot -f" in the end. And this is like force reboot and
will not contact systemd.
IOW, kernel will directly shutdown user space, not letting systemd to do
such job.
And why are we doing it? I think we had discussed this in the past just
that I can't remember the detail.
Why shouldn't we go through regular reboot path. What's so special that
we need to enforce "reboot -f" ourselves.
Thanks
Vivek