On Tue, Sep 23, 2014 at 10:19:35AM +0800, Baoquan He wrote:
On 09/22/14 at 11:15am, Vivek Goyal wrote:
> On Mon, Sep 22, 2014 at 02:07:46PM +0800, Baoquan He wrote:
> > On 09/22/14 at 11:24am, Minfei Huang wrote:
> > > If the grub kernel commandline is set to crashkernel=auto, it will not
> > > expand the crashkernel=auto in the /proc/cmdline. It still says
> > > crashkernel=auto.
> > >
> > > Using /sys to determines crashkernel actual size is confusing since
> > > there is no unit of measure.
> > >
> > > Add a new command "kdumpctl showmem" to show the reserved memory
kindly.
> >
> > Hi Minfei,
> >
> > I don't think this is necessary. kdumpctl is used to manage the kdump
> > kernel load/unload, we don't need to provide another option to show how
> > much crash memory is reserved. I think /sys/kernel/kexec_xxx is enough.
>
>
> Bao,
>
> Agreed that it is not necessary. Just that it makes it easier for some
> people. I have a bug open for this. If it makes it easier to find how
> much memory is reserved, it does not harm.
OK, I am fine with it. Just worry other requirements also can be added
into kdumpctl to make it a little mess if this is started. Anyway, I
don't object to this strongly.
Ok, I am checking with Jeff Burke and see if he still like to see it. If
he agrees, then we can drop it.
Thanks
Vivek