Hi,
Thanks for the patch, ccing David for more review since this is based on
his github implementation.
I have a few minor comments. Otherwise I'm fine.
Next step should be
1. update kexec-tools.spec to create a subpackage
2. update and merge original firstboot po files, upload them to look aside cache server
3. If everything is ok, then we can remove the firstboot related code.
4. upload new po files for translating. I think there's only a few new words, most of
them have been translated in original firstboot po files already.
On 05/04/14 at 10:39am, Arthur Zou wrote:
Currently this work is done by firstboot. Now we move to anaconda
addon
to configurate in the system installation process.
Signed-off-by: Arthur Zou <zzou(a)redhat.com>
---
addon-Makefile | 82 ++++++++++++
addon-README | 32 +++++
addon-__init__.py | 0
addon-common.py | 88 ++++++++++++
addon-constants.py | 23 ++++
addon-gui-__init__.py | 0
addon-gui-spokes-__init__.py | 0
addon-gui-spokes-fedora.glade | 218 ++++++++++++++++++++++++++++++
addon-gui-spokes-kdump.glade | 274 ++++++++++++++++++++++++++++++++++++++
addon-gui-spokes-kdump.py | 192 ++++++++++++++++++++++++++
addon-i18n.py | 27 ++++
addon-ks-__init__.py | 0
addon-ks-kdump.py | 128 ++++++++++++++++++
addon-po-Makefile | 78 +++++++++++
addon-po-kdump-anaconda-addon.pot | 81 +++++++++++
addon-tui-__init__.py | 0
addon-tui-spokes-__init__.py | 0
addon-tui-spokes-kdump.py | 87 ++++++++++++
18 files changed, 1310 insertions(+)
create mode 100644 addon-Makefile
create mode 100644 addon-README
create mode 100644 addon-__init__.py
create mode 100644 addon-common.py
create mode 100644 addon-constants.py
create mode 100644 addon-gui-__init__.py
create mode 100644 addon-gui-spokes-__init__.py
create mode 100644 addon-gui-spokes-fedora.glade
create mode 100644 addon-gui-spokes-kdump.glade
create mode 100644 addon-gui-spokes-kdump.py
create mode 100644 addon-i18n.py
create mode 100644 addon-ks-__init__.py
create mode 100644 addon-ks-kdump.py
create mode 100644 addon-po-Makefile
create mode 100644 addon-po-kdump-anaconda-addon.pot
create mode 100644 addon-tui-__init__.py
create mode 100644 addon-tui-spokes-__init__.py
create mode 100644 addon-tui-spokes-kdump.py
diff --git a/addon-Makefile b/addon-Makefile
new file mode 100644
index 0000000..74415bd
--- /dev/null
+++ b/addon-Makefile
@@ -0,0 +1,82 @@
+NAME = kdump-anaconda-addon
+
+VERSION = 0.1
+
+ADDON = com_redhat_kdump
+TESTS = test
+
+FILES = $(ADDON) \
+ $(TESTS) \
+ po \
+ LICENSE \
There's no LICENSE file, thus remove above line?
[snip]
new file mode 100644
index 0000000..fbd1cbd
--- /dev/null
+++ b/addon-README
@@ -0,0 +1,32 @@
+This is an anaconda addon for configuring kdump. To use, copy the
+com_redhat_kdump directory into /usr/share/anaconda/addons on your
+installation media. /etc/kdump.conf will also be needed in the installation
+environment to provide the default contents of /etc/kdump.conf on the
+installed system.
/etc/kdump.conf is not necessary because the addon only handle crashkernel param.
[snip]
diff --git a/addon-gui-spokes-kdump.glade
b/addon-gui-spokes-kdump.glade
new file mode 100644
index 0000000..e0bd55f
--- /dev/null
+++ b/addon-gui-spokes-kdump.glade
So these two glade files are for Fedora and RHEL, how about change the file
name to ddon-gui-spokes-RHEL.glade
[snip]
diff --git a/addon-gui-spokes-kdump.py b/addon-gui-spokes-kdump.py
new file mode 100644
index 0000000..7523acf
--- /dev/null
+++ b/addon-gui-spokes-kdump.py
Ditto, how about rename to "addon-gui-spokes-RHEL.py"
[snip]
Thanks
Dave